[microTVM][Zephyr] Add skip for AOT test #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
|
@mehrdadh Thanks a lot for improving the AOT test suite by skipping boards like ST Disco board, where the test in question doesn't fit! Also thanks for making it clear that the error number is a hex number. Small but important changes! :) The CI has failed, but I've got the same error in "BUILD: CPU" for my changes in PR 8613, which is a pure textual change, so I believe it's a CI glitch again (re-trigger so?). Bummer. The change LGTM! |
gromero
approved these changes
Aug 3, 2021
gromero
approved these changes
Aug 3, 2021
|
thanks for the review @gromero! I just triggered it. |
Mousius
approved these changes
Aug 6, 2021
leandron
approved these changes
Aug 6, 2021
mehrdadh
added a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
* add hex indicator to message * add pytest skip * trigger * trigger
mehrdadh
added a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
* add hex indicator to message * add pytest skip * trigger * trigger
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* add hex indicator to message * add pytest skip * trigger * trigger
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* add hex indicator to message * add pytest skip * trigger * trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pytest.skipfor platforms that cannot fit the model.