Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY][FRONTEND] Initial OneFlow frontend support. #8790

Merged
merged 37 commits into from
Apr 15, 2022

Conversation

hhhfccz
Copy link
Contributor

@hhhfccz hhhfccz commented Aug 19, 2021

Initial OneFlow frontend support, also add tutorials and tests.
tested models:

  • alexnet
  • mobilenetv2
  • resnet50
  • SRGAN
  • yolov3

@hhhfccz
Copy link
Contributor Author

hhhfccz commented Aug 19, 2021

@areusch @comaniac @Huyuwei

@BBuf
Copy link
Contributor

BBuf commented Aug 19, 2021

Hello, TVM developers. We have recently done a work to add a new deep learning framework OneFlow to the TVM front-end, hope this work can be received.

@tqchen

@comaniac
Copy link
Contributor

Thanks for the PR. For large scope new features, we recommend to file an RFC first to propose the motivation, approach and interfaces to the community for discussions. Please see the guideline here: https://github.com/apache/tvm-rfcs

@junrushao
Copy link
Member

Yeah we find it super exciting and happy to discuss more with the RFC process

@leandron leandron added the status: need RFC need RFC discussion label Aug 19, 2021
@leandron leandron removed the status: need RFC need RFC discussion label Aug 20, 2021
@BBuf
Copy link
Contributor

BBuf commented Feb 28, 2022

Have you reproduced that issue locally using docker?

Does oneflow depend on libibverbs?

It is not depend on libibverbs

@BBuf
Copy link
Contributor

BBuf commented Feb 28, 2022

The tests related to the oneflow front-end in ci have all passed (indicating that oneflow can be imported normally), but it only hangs when the html corresponding to the document is compiled, and no specific reason is given. But I can run this from_oneflow.py normally in local. If it is convenient, can you help to confirm the source of this error? I compared the format of from_oneflow.py and from_onnx.py line by line, and found no problem. Thanks! @masahi

@masahi
Copy link
Member

masahi commented Feb 28, 2022

I think CI is not running any oneflow tests. You need to update https://github.com/apache/tvm/blob/main/tests/scripts/task_python_frontend.sh

It is not depend on libibverbs

Can you do more investigation on this. It may depend on it indirectly via other deps. Remember that we are using the oneflow CPU build.

@BBuf
Copy link
Contributor

BBuf commented Mar 1, 2022

I think CI is not running any oneflow tests. You need to update https://github.com/apache/tvm/blob/main/tests/scripts/task_python_frontend.sh

It is not depend on libibverbs

Can you do more investigation on this. It may depend on it indirectly via other deps. Remember that we are using the oneflow CPU build.

Ok, thanks.

@areusch
Copy link
Contributor

areusch commented Apr 8, 2022

@BBuf is this ready for another look?

@BBuf
Copy link
Contributor

BBuf commented Apr 9, 2022

@BBuf is this ready for another look?

Yes, but the problem here is that CI will have a segment fault bug when build html, but I can't reproduce it here, this is my pain point. So, can i get some help? thanks!

@areusch
Copy link
Contributor

areusch commented Apr 11, 2022

@BBuf can you try using our new ci.py tool (still kinda in dev, but supports docs)? it should reproduce locally. if not, then i guess we have a more annoying problem, probably specific to a GPU used in CI (also--do you have an nvidia GPU available locally?).

i think tests/scripts/ci.py docs should repro the CI locally, there are a few other options you might try there.

@BBuf
Copy link
Contributor

BBuf commented Apr 15, 2022

if not, then i guess we have a more annoying problem, probably specific to a GPU used in CI (also--do you have an nvidia GPU available locally?).

Thank you very much. I run tests/scripts/ci.py docs locally, but I can't reproduce the build html error, it's normally.

图片

but in ci, some strange bug appeared, link

图片

@areusch @masahi

@masahi
Copy link
Member

masahi commented Apr 15, 2022

Maybe some problem is happening during

generating gallery for how_to/compile_models... [100%] from_oneflow.py

How about removing from_oneflow.py for now and get the rest merged, and worry about the tutorial later?

@BBuf
Copy link
Contributor

BBuf commented Apr 15, 2022

Maybe some problem is happening during

generating gallery for how_to/compile_models... [100%] from_oneflow.py

How about removing from_oneflow.py for now and get the rest merged, and worry about the tutorial later?

Ok, I'll have a try.

@masahi masahi merged commit 29774bd into apache:main Apr 15, 2022
@masahi
Copy link
Member

masahi commented Apr 15, 2022

@BBuf @hhhfccz sorry it took so long, but this is finally merged!

@BBuf
Copy link
Contributor

BBuf commented Apr 15, 2022

Thanks. I will rewrite the tutorial in my next PR.

Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
* add relay.f.frontend.fm_oneflow support cnns

* support cuda

* fix mobilenetv2 and reviews

* fix: model without meta info

* support eager and yolo, add test

* fix: license

* add: tutorials

* fix: support new graph

* fix some comments

* refine

* fix concat op convert bug

* refine

* refine

* change cuda to cpu

* fix bug

* fix ci error in tvm

* fix pylint check

* delete useless file

* add skimage package in docker

* fix ci error

* fix bug

* add oneflow fronted test in ci

* merge conflict

* fix tutorial

* try to find error in ci

* revert

* merge conflict

* black oneflow

* Delete from_oneflow.py

Co-authored-by: Xiaoyu Zhang <[email protected]>
Co-authored-by: BBuf <[email protected]>
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
* add relay.f.frontend.fm_oneflow support cnns

* support cuda

* fix mobilenetv2 and reviews

* fix: model without meta info

* support eager and yolo, add test

* fix: license

* add: tutorials

* fix: support new graph

* fix some comments

* refine

* fix concat op convert bug

* refine

* refine

* change cuda to cpu

* fix bug

* fix ci error in tvm

* fix pylint check

* delete useless file

* add skimage package in docker

* fix ci error

* fix bug

* add oneflow fronted test in ci

* merge conflict

* fix tutorial

* try to find error in ci

* revert

* merge conflict

* black oneflow

* Delete from_oneflow.py

Co-authored-by: Xiaoyu Zhang <[email protected]>
Co-authored-by: BBuf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants