Set default value of p in LpPool as 2 #8866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luyaor
requested review from
areusch,
comaniac,
Huyuwei,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
vinx13
approved these changes
Aug 27, 2021
jwfromm
approved these changes
Aug 27, 2021
|
Looks like the added test case in this PR doesn't pass CI, can you try this test case locally to see if it can be reproduced? |
Fix bug in test.
|
Sorry, I incorrectly calculate the output shape of test input. It should be correct now. :) |
|
Thanks Luyao! It all looks good to me |
junrushao
approved these changes
Aug 31, 2021
|
@luyaor CI failed for unrelated things, could you push again to retrigger CI? |
|
nvm I retriggered CI |
|
Looks like |
vinx13
reviewed
Sep 1, 2021
There was a problem hiding this comment.
This is the error on CI
E onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Node: Output:y [ShapeInferenceError] Can't merge shape info. Both source and target dimension have values but they differ. Source=32 Target=31 Dimension=2
Seems the previous output shape [1, 1, 32, 32] was correct?
mbrookhart
approved these changes
Sep 1, 2021
update with correct shape.
|
updated. |
vinx13
requested changes
Sep 1, 2021
|
Updated. |
vinx13
approved these changes
Sep 2, 2021
vinx13
reviewed
Sep 2, 2021
Co-authored-by: Wuwei Lin <[email protected]>
|
Thanks @luyaor @vinx13 @junrushao1994 @jwfromm ! |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 2, 2021
* main: [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests (apache#8902) [BUG] DataType Bug In SplitRel (apache#8899) Enable python debug runtime for exported network libraries (apache#8793) Set default value of p in LpPool as 2 (apache#8866) [Community] @Hzfengsy -> Committer (apache#8908) Trivial uTVM -> microTVM "spelling" fix to align with branding. (apache#8905) [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures (apache#8904) Move to new style issue template system (apache#8898) [Onnx] Support Negative Log Loss (apache#8872) [ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896) fix error report on Store (apache#8895) [Docker] Re-enabled automatic --tty flag when running bash. (apache#8861)
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Set default value of p in LpPool as 2 * Update test_forward.py Fix bug in test. * Update test_forward.py update with correct shape. * Update onnx.py * Update python/tvm/relay/frontend/onnx.py Co-authored-by: Wuwei Lin <[email protected]> Co-authored-by: luyaor <[email protected]> Co-authored-by: Wuwei Lin <[email protected]>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Set default value of p in LpPool as 2 * Update test_forward.py Fix bug in test. * Update test_forward.py update with correct shape. * Update onnx.py * Update python/tvm/relay/frontend/onnx.py Co-authored-by: Wuwei Lin <[email protected]> Co-authored-by: luyaor <[email protected]> Co-authored-by: Wuwei Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwfromm Sorry for very late update. Followed #7242.
I have already formatted the code based on #7242 (comment).
Hope to merge :)