Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hexagon] Treat floats as float32 when passing args to offloaded kernels #9010

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[Hexagon] Treat floats as float32 when passing args to offloaded kernels #9010

merged 1 commit into from
Sep 15, 2021

Commits on Sep 14, 2021

  1. [Hexagon] Treat floats as float32 when passing args to offloaded kernels 

    `TVMArg` can hold a floating point value, but it's stored as `double`. In
Hexagon ABI doubles are passed in a register pair, but if the offloaded
function was using floats (i.e. float32), it will expect values being
passed in single registers. Since floats are much more common on Hexagon,
assume all scalar floating point values are floats. This is only an issue
with offloading, and can be treated as a limitation (we do something
analogous for integers already).
    Krzysztof Parzyszek committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    9eda121 View commit details
    Browse the repository at this point in the history