Introduce centralised name transformation functions #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
Mousius
force-pushed
the
centralised-name-mangling
branch
2 times, most recently
from
c34563e
to
bc8a3bc
Compare
To address some of the concerns raised in apache#8280 and apache#8720 I've put together a series of functions to combine together names to re-use between these areas. These are meant to be a starting point to fix up the name generation to use the TVM C conventions and port the interface API header to C++. These functions will also be used for constructing the names in the C Device API (apache/tvm-rfcs#31).
Mousius
force-pushed
the
centralised-name-mangling
branch
from
bc8a3bc
to
33338bd
Compare
jroesch
removed request for
wweic,
yzhliu,
tqchen,
MarisaKirisame,
mbrookhart,
zhiics,
slyubomirsky,
vinx13,
comaniac and
jwfromm
jroesch
removed request for
anijain2305,
merrymercy,
ZihengJiang and
junrushao
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Sep 24, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Sep 24, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
This patch aims to sanitize uses of sanitise to the form of sanitize to be consistent with the overall codebases use of American English.
|
@areusch I've made the requested changes barring the discussion around how to name the functions. Could you please take another look? 😸 |
|
@Mousius my only question is basically if we'll also update |
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Sep 30, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 30, 2021
* main: (80 commits) Introduce centralised name transformation functions (apache#9088) [OpenCL] Add vectorization to cuda conv2d_nhwc schedule (apache#8636) [6/6] Arm(R) Ethos(TM)-U NPU codegen integration with `tvmc` (apache#8854) [microTVM] Add wrapper for creating project using a MLF (apache#9090) Fix typo (apache#9156) [Hotfix][Testing] Wait for RPCServer to be established (apache#9150) Update find cublas so it search default path if needed. (apache#9149) [TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer (apache#9145) Fix flaky NMS test by making sure scores are unique (apache#9140) [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038) [LLVM] Make changes needed for opaque pointers (apache#9138) Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849) [CI] Split Integration tests out of first phase of pipeline (apache#9128) [Meta Schedule][M3b] Runner (apache#9111) Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141) [TIR] add loop partition hint pragma (apache#9121) fix things (apache#9146) [Meta Schedule][M3a] SearchStrategy (apache#9132) [Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133) [UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143) ...
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Oct 1, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
manupak
pushed a commit
that referenced
this pull request
Oct 8, 2021
Using the new name transformations added in #9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes #8792
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Introduce centralised name transformation functions To address some of the concerns raised in apache#8280 and apache#8720 I've put together a series of functions to combine together names to re-use between these areas. These are meant to be a starting point to fix up the name generation to use the TVM C conventions and port the interface API header to C++. These functions will also be used for constructing the names in the C Device API (apache/tvm-rfcs#31). * Improve error handling and error messages * Sanitize sanitise to sanitize This patch aims to sanitize uses of sanitise to the form of sanitize to be consistent with the overall codebases use of American English.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Introduce centralised name transformation functions To address some of the concerns raised in apache#8280 and apache#8720 I've put together a series of functions to combine together names to re-use between these areas. These are meant to be a starting point to fix up the name generation to use the TVM C conventions and port the interface API header to C++. These functions will also be used for constructing the names in the C Device API (apache/tvm-rfcs#31). * Improve error handling and error messages * Sanitize sanitise to sanitize This patch aims to sanitize uses of sanitise to the form of sanitize to be consistent with the overall codebases use of American English.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address some of the concerns raised in #8280 and #8720 I've put together a series of functions to combine together names to re-use between these areas. These are meant to be a starting point to fix up the name generation to use the TVM C conventions and port the interface API header to C++.
These functions will also be used for constructing the names in the C Device API (apache/tvm-rfcs#31)
cc @Raghav-Chakravarthy @areusch