Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Script][TensorIR] update block syntax #9286

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

Hzfengsy
Copy link
Member

This PR is for updating block syntax. Please see RFC: here

cc @junrushao1994 @tqchen @tkonolige

@junrushao
Copy link
Member

Thanks @Hzfengsy! It's a painstaking refactor and finally you made it!

Copy link
Contributor

@shingjan shingjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge effort! Is there a RFC or thread that one can follow to see the significance of this refactor?

@Hzfengsy Hzfengsy force-pushed the block_syntax branch 3 times, most recently from 2ac3e54 to 245966d Compare October 15, 2021 03:23
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

Let's get it merged on Monday just to avoid weekend merge.

@tqchen tqchen merged commit d23688c into apache:main Oct 18, 2021
@Hzfengsy Hzfengsy deleted the block_syntax branch October 19, 2021 05:29
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants