[Hexagon] Introduce new DeviceAPI #9355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
building for hexagon and USE_HEXAGON_DEVICE is not set.
tvm runtime logging for hexagon.
that wraps params in an unmanaged HexagonBuffer.
csullivan
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
tqchen,
vinx13 and
ZihengJiang
as code owners
jroesch
reviewed
Oct 26, 2021
| * under the License. | ||
| */ | ||
|
|
||
| #ifndef TVM_RUNTIME_HEXAGON_HEXAGON_HEXAGON_DEVICE_API_V2_H_ |
There was a problem hiding this comment.
Is the reason to name this v2 because we are keeping v1 around?
jroesch
approved these changes
Oct 26, 2021
|
cc @mbs-octoml |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Compile hexagon device api from runtime/hexagon/hexagon when building for hexagon and USE_HEXAGON_DEVICE is not set. * Add hexagon_common.h utilities including custom tvm runtime logging for hexagon. * Introduce HexagonBuffer class to store hexagon allocation metadata. * Add HexagonDeviceAPIv2 for use on hexagon. * Add hexagon packed function wrapper. * Add custom linked param lookup for hexagon that wraps params in an unmanaged HexagonBuffer. * Add custom hexagon module based of library module node. * Apply clang formatting * Apply cpplint changes.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Compile hexagon device api from runtime/hexagon/hexagon when building for hexagon and USE_HEXAGON_DEVICE is not set. * Add hexagon_common.h utilities including custom tvm runtime logging for hexagon. * Introduce HexagonBuffer class to store hexagon allocation metadata. * Add HexagonDeviceAPIv2 for use on hexagon. * Add hexagon packed function wrapper. * Add custom linked param lookup for hexagon that wraps params in an unmanaged HexagonBuffer. * Add custom hexagon module based of library module node. * Apply clang formatting * Apply cpplint changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Hexagon DeviceAPI is intended for cross compilation directly to Hexagon. This is distinct from the current device api which is compiled and run on the android arm CPU. This includes:
Alternatives: Internally cache HexagonBuffer structure in DeviceAPI and return raw allocation pointer.
Depends on #9354, #9342.