-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetaSchedule][M4b] Misc improvement of the Measurer #9757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! @sunggg let's fix the CI :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey you forgot the fix the two "ditto"s :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@junrushao1994, Aren't there three files in total? I'm now seeing this message.
Since I'm new to this system, any advice would be greatly appreciated! |
Oh I’m sorry that I misread! The linter error this time is that we forgot to add docs for “params” in c++ |
CC @zxybazh for review |
56347b7
to
c4860b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @sunggg !
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Co-authored-by: Junru Shao <[email protected]>
Nice to meet you all.
This PR contains several changes in meta_scheudle runner and builder.
Please review this and feel free to give any feedback.
Thank you!