Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on Windows if namespace contains whitespace #303

Closed
viorell91 opened this issue Jan 30, 2023 · 0 comments
Closed

Build fails on Windows if namespace contains whitespace #303

viorell91 opened this issue Jan 30, 2023 · 0 comments
Assignees
@reckart
Labels
🦟 Bug Something isn't working
Milestone
3.4.1

Comments

@viorell91
Copy link

Describe the bug
When Building uimaj-core from sources on Windows, a single whitespace in the namespace leads to failed test ImportResolverTest.testTransitiveResolveImports.

Stacktrace:

[ERROR] Failures:
[ERROR]   ImportResolverTest.testTransitiveResolveImports:110
Expecting actual:
  {"file:/C:/Users/morari/Downloads/Neuer Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Transitive-with-3-nodes-2.xml"=org.apache.uima.resource.metadata.impl.TypeSystemDescription_impl:
[...]
to contain only following keys:
  ["file:/C:/Users/morari/Downloads/Neuer%20Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-2.xml",
    "file:/C:/Users/morari/Downloads/Neuer%20Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-3.xml"]
keys not found:
  ["file:/C:/Users/morari/Downloads/Neuer%20Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-2.xml",
    "file:/C:/Users/morari/Downloads/Neuer%20Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-3.xml"]
and keys not expected:
  ["file:/C:/Users/morari/Downloads/Neuer Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-2.xml",
    "file:/C:/Users/morari/Downloads/Neuer Ordner/uimaj-3.4.0-RC-202301261003-3ce0551/uimaj-3.4.0-source-release/uimaj-3.4.0/uimaj-core/target/test-classes/ImportResolverTest/Loop-with-3-nodes-3.xml"]

here the parent folder contains a whitespace: Neuer Ordner

To Reproduce
Steps to reproduce the behavior:

  1. Build from sources, on Windows, where the source's namespace contains at least a whitespace.
  2. See error

Expected behavior
Successful build from sources on Windows, while path contains a whitespace.

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

  • Version: 3.4.0
  • OS: Windows 10
@viorell91 viorell91 added the 🦟 Bug Something isn't working label Jan 30, 2023
@reckart reckart added this to the 3.4.1 milestone Feb 2, 2023
@reckart reckart changed the title uimaj-core build fails on Windows if namespace contains whitespace Build fails on Windows if namespace contains whitespace Feb 17, 2023
@reckart reckart self-assigned this Feb 17, 2023
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Issue #303: Build fails on Windows if namespace contains whitespace
a5a8e91 
- Try using deprecated non-escaping toURL() because it seems that  might be what the tested code is using internally as well
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Issue #303: Build fails on Windows if namespace contains whitespace
d09c442 
- Try using deprecated non-escaping toURL() because it seems that  might be what the tested code is using internally as well
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Issue #303: Build fails on Windows if namespace contains whitespace
4b19991 
- Fix another space-in-path-windowsism
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Issue #303: Build fails on Windows if namespace contains whitespace
0440da9 
- Try using deprecated non-escaping toURL() because it seems that  might be what the tested code is using internally as well
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Issue #303: Build fails on Windows if namespace contains whitespace
ba038b2 
- "Fix" test to cope with apparent inconsistency in the core framework
reckart added a commit that referenced this issue Feb 17, 2023
@reckart
Merge pull request #309 from apache/bugfix/303-Build-fails-on-Windows…
dacb7b8 
…-if-namespace-contains-whitespace

Issue #303: Build fails on Windows if namespace contains whitespace
@reckart reckart closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🦟 Bug Something isn't working
Projects
None yet
Milestone
3.4.1
Development

No branches or pull requests
2 participants
@reckart @viorell91