Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #234: Using builtin annotation classes before creating a CAS can break type system management #243

Draft
wants to merge 1 commit into
base: release/3.3.x
Choose a base branch
from

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 15, 2022

What's in the PR

  • Try fixing the case if a JCCI was created with a bad type ID because the type ID had not been set yet

How to test manually

  • Try running the ClearTK TimeMlAnnotateTest caugh

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

…n break type system management

- Try fixing the case if a JCCI was created with a bad type ID because the type ID had not been set yet
@reckart reckart added the 🦟 Bug Something isn't working label Aug 15, 2022
@reckart reckart added this to the 3.3.1 milestone Aug 15, 2022
@reckart reckart self-assigned this Aug 15, 2022
@azazali30
Copy link

@reckart are we merging this fix, we are waiting for this fix to merge so that we can proceed with refactoring/442-Upgrade-to-UIMAv3

@reckart
Copy link
Member Author

reckart commented Aug 31, 2022

There is no fix yet - I need to find time to investigate it further because changes in this PR do not yet resolve the problem.

The alternative would be a workaround. I think it might be sufficient to create a dummy CAS before the failing tests accesses the JCas classes.

@reckart reckart modified the milestones: 3.3.1, 3.3.2 Oct 17, 2022
@reckart
Copy link
Member Author

reckart commented Jan 12, 2023

The work in this branch so far is unable to fix the problem.

The recommended workaround is to create a CAS object before working with any JCas classes.

@reckart reckart modified the milestones: 3.3.2, 3.4.1 Feb 7, 2023
@reckart reckart modified the milestones: 3.4.1, 3.4.2 Feb 17, 2023
@reckart reckart modified the milestones: 3.4.2, 3.4.3 Jun 29, 2023
@reckart reckart marked this pull request as draft October 12, 2023 11:46
reckart added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants