[YUNIKORN-2760] make tools should check the version of tools
#880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 67.30% 68.06% +0.75%
==========================================
Files 70 70
Lines 7625 7624 -1
==========================================
+ Hits 5132 5189 +57
+ Misses 2274 2217 -57
+ Partials 219 218 -1 ☔ View full report in Codecov by Sentry. |
|
@blueBlue0102 please check the e2e test output, something is wrong with the "ginkgo" command, I suppose it is related to your change. |
blueBlue0102
force-pushed
the
YUNIKORN-2760
branch
from
faf2c6b
to
1a28948
Compare
|
@pbacsko The problem has been solved, and the e2e test has passed on my forked repo. Please let me know if there are any further issues. Thank you! |
|
@blueBlue0102 thanks for this great improvement! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Makefile, by default, checks only the existence of file. Hence, developers need to remove tools folder (or call
make distclean) manually to trigger the installation after we update the version of tools.However, how developers can be aware of the tools updates? Personally, I smell fishy from the error of warning, but that could be implicit and noisy :cry
In order to fix that, I'd like to introduce the new folder structure to tools folder:
That offers a unique path to each version of tool. Developers will not miss the updates anymore.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2760
How should this be tested?
Currently,
make toolsis triggered only by./scripts/run-e2e-tests.shTo verify whether
make toolschecks the tools' versions, call any command in./scripts/run-e2e-tests.shor trigger it manuallyScreenshots (if appropriate)