Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2808] E2E test Verify_preemption_on_priority_queue test is flaky #897

Closed
wants to merge 1 commit into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

E2E test Verify_preemption_on_priority_queue test is flaky

What type of PR is it?

  • - Bug Fix

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (2278b32) to head (9c6a45d).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   67.84%   67.89%   +0.05%     
==========================================
  Files          70       70              
  Lines        7485     7488       +3     
==========================================
+ Hits         5078     5084       +6     
+ Misses       2195     2192       -3     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manirajv06
Copy link
Contributor Author

Preemption use single node for all these tests for simplicity. Failures happened only in Verify_preemption_on_priority_queue test. In this test, app submitted in low-priority queue has entered into reservation flow instead of going through preemption flow and eventually rejected because of its lower priority, followed by app waiting in high-priority queue not being able to complete the preemption because of node reserved by app submitted in low-priority queue. This specific situation doesn't happen always in all runs. Now, modified a test a bit to trigger the preemption while the headroom checks itself for both the apps so that high priority app is able to get resources through preemption whereas low priority app is not able to.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants