[YUNIKORN-2830] Update Kubernetes compile dependency to 1.31.0 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 67.91% 67.80% -0.11%
==========================================
Files 70 70
Lines 7493 7558 +65
==========================================
+ Hits 5089 5125 +36
- Misses 2192 2219 +27
- Partials 212 214 +2 ☔ View full report in Codecov by Sentry. |
craigcondit
force-pushed
the
YUNIKORN-2830
branch
from
6057496
to
cf6d68e
Compare
wilfred-s
requested changes
Aug 26, 2024
go.mod
Outdated
| ) | ||
|
|
||
| replace ( | ||
| github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.12 | ||
| github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.13 |
There was a problem hiding this comment.
needs to be remove, we had it for a CVE fix but that is no longer needed, k8s 1.31 has moved to runc 1.1.13
go.mod
Outdated
| ) | ||
|
|
||
| replace ( | ||
| github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.12 | ||
| github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.13 | ||
| github.com/petermattis/goid => github.com/petermattis/goid v0.0.0-20240327183114-c42a807a84ba |
There was a problem hiding this comment.
we should update to the latest go-deadlock 0.3.5 to get the up to date version of this.
go.mod
Outdated
Comment on lines
173
to
178
| golang.org/x/crypto => golang.org/x/crypto v0.24.0 | ||
| golang.org/x/lint => golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 | ||
| golang.org/x/net => golang.org/x/net v0.23.0 | ||
| golang.org/x/sys => golang.org/x/sys v0.18.0 | ||
| golang.org/x/text => golang.org/x/text v0.14.0 | ||
| golang.org/x/tools => golang.org/x/tools v0.17.0 | ||
| google.golang.org/protobuf => google.golang.org/protobuf v1.33.0 | ||
| k8s.io/api => k8s.io/api v0.29.6 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.29.6 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.29.6 | ||
| k8s.io/apiserver => k8s.io/apiserver v0.29.6 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.29.6 | ||
| k8s.io/client-go => k8s.io/client-go v0.29.6 | ||
| k8s.io/cloud-provider => k8s.io/cloud-provider v0.29.6 | ||
| k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.29.6 | ||
| k8s.io/code-generator => k8s.io/code-generator v0.29.6 | ||
| k8s.io/component-base => k8s.io/component-base v0.29.6 | ||
| k8s.io/component-helpers => k8s.io/component-helpers v0.29.6 | ||
| k8s.io/controller-manager => k8s.io/controller-manager v0.29.6 | ||
| k8s.io/cri-api => k8s.io/cri-api v0.29.6 | ||
| k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.29.6 | ||
| k8s.io/dynamic-resource-allocation => k8s.io/dynamic-resource-allocation v0.29.6 | ||
| k8s.io/endpointslice => k8s.io/endpointslice v0.29.6 | ||
| golang.org/x/net => golang.org/x/net v0.26.0 | ||
| golang.org/x/sys => golang.org/x/sys v0.21.0 | ||
| golang.org/x/text => golang.org/x/text v0.16.0 | ||
| golang.org/x/tools => golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d |
There was a problem hiding this comment.
Can we move to the latest of all of these:
golang.org/x/crypto => golang.org/x/crypto v0.26.0
golang.org/x/net => golang.org/x/net v0.28.0
golang.org/x/sys => golang.org/x/sys v0.24.0
golang.org/x/text => golang.org/x/text v0.17.0
golang.org/x/tools => golang.org/x/tools v0.24.0
I still think we need to keep them in their own replace outside of the K8s dependencies
go.mod
Outdated
| golang.org/x/sys => golang.org/x/sys v0.21.0 | ||
| golang.org/x/text => golang.org/x/text v0.16.0 | ||
| golang.org/x/tools => golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d | ||
| google.golang.org/protobuf => google.golang.org/protobuf v1.34.2 |
There was a problem hiding this comment.
We need to update the scheduler-interface protobuf version and pull that one in then we should not need this one. K8s has already updated this in 1.31 Updates need to flow from SI -> core -> k8shim
There was a problem hiding this comment.
SI ref updated, core PR is submitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update our compile-time dependency on Kubernetes to v1.31.0. Also ensure that we are instantiating all required informers for scheduler plugins (there were several missing).
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2830
How should this be tested?
Existing e2e tests should pass.
Screenshots (if appropriate)
Questions: