Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2582]Update atomic.Int32 for atomic operations #899

Closed
wants to merge 2 commits into from

Conversation

SophieTech88
Copy link
Contributor

What is this PR for?

Type atomic.Int32 was introduced in go 1.19, we should adopt it for better code clarity.

Below variable type should be changed:

  1. asyncDispatchCount in dispatcher.go
  2. registerCount/UpdateAllocationCount/UpdateApplicationCount/UpdateNodeCount in schedulerapi_mock.go

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

All unit tests should be passed.

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit
Copy link
Contributor

Assuming PR will be updated with the other locations? (schedulerapi_mock.go)

@SophieTech88
Copy link
Contributor Author

Assuming PR will be updated with the other locations? (schedulerapi_mock.go)

Hahaha. You are right. The second is coming~

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (78e1d71) to head (5dbaf18).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/common/test/schedulerapi_mock.go 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   67.91%   67.89%   -0.02%     
==========================================
  Files          70       70              
  Lines        7493     7489       -4     
==========================================
- Hits         5089     5085       -4     
  Misses       2192     2192              
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants