Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2911] Add kind-e2e Makefile target #925

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Adds a simple kind-e2e Makefile target. This target starts a kind cluster on the latest version, executes the e2e tests, and tears down the cluster.

Ideally this should be run by users prior to PR pushes.

Also, update to kind image for v1.31.1.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2911

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Adds a simple kind-e2e Makefile target. This target starts a kind
cluster on the latest version, executes the e2e tests, and tears down
the cluster.

Ideally this should be run by users prior to PR pushes.

Also, update to kind image for v1.31.1.
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (ac4f141) to head (03f2703).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   68.21%   68.28%   +0.06%     
==========================================
  Files          70       70              
  Lines        7621     7611      -10     
==========================================
- Hits         5199     5197       -2     
+ Misses       2213     2206       -7     
+ Partials      209      208       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@craigcondit craigcondit deleted the YUNIKORN-2911 branch October 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants