[YUNIKORN-1779] Deduplicate the deployment files #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2023
|
@targetoee please fix the license check issues and re-submit the PR. |
|
Hi @craigcondit thanks for the reminder. Fix it. |
|
The more I look at this, the more I think it doesn't belong here. The helm charts in yunikorn-release should be kept pristine, and we shouldn't have extra scripts such as this in the release repo. If anything, we could script this out from the k8shim repo by referencing the real charts via helm (similar to how we reference them for doing dev cluster installs already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
YUNIKORN-1779
explanation
Currently, there are two sets of deployment files that are very similar but located in two different projects:
yunikorn-release/helm-charts/yunikornandyunikorn-k8shim/deployments/scheduler. These files tend to get out of sync.Considering that there may be situations where raw YAML files are needed instead of using Helm, a script has been added to generate these raw YAML files to provide convenience.
related PRs
#679
#350