[YUNIKORN-2135] Add integration test code coverage #164
Conversation
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
YUNIKORN-2135
branch
from
bc26a58
to
cdd2d90
Compare
| volumes: | ||
| - name: go-cover-dir | ||
| hostPath: | ||
| path: /go-cover-dir/ | ||
| type: DirectoryOrCreate | ||
| {{- end }} |
There was a problem hiding this comment.
If follow this approach, I believe we'll need extra code somewhere which fetches the results from the Docker containers if we want to automate this, correct? Because we won't have it right away on the host filesystem. I guess we need a docker cp somewhere.
There was a problem hiding this comment.
Yes, like copy_go_cover_dir function in https://github.com/apache/yunikorn-k8shim/pull/733/files#diff-6d485e1346af49aeb05caeb7af55511940214789cd6976f03afa05e56b82d639R156-R177.
There was a problem hiding this comment.
+1 looks good. Internally we'll need PVC support other than HostPath but I believe it's good for a start.
cc @wilfred-s
There was a problem hiding this comment.
I'm -1 on this. I am really not a fan of polluting our helm charts with additional cruft that is completely useless for end users. This is just going to lead to confusion. If we're going to do this as part of e2e testing fine; there needs to be a way to dynamically add this from within the k8shim repo, not in the primary helm charts used here in yunikorn-release.
What is this PR for?
Add a new value
enableGoCoverDir. If the value istrue, we add an output folder and setGOCOVERDIRfor yunikorn deployment.What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2135