Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1970] Fix outdated metrics document #335

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

brandboat
Copy link
Member

What is this PR for?

https://yunikorn.apache.org/docs/next/performance/metrics has never been updated after be96059. Part of the metrics documentation not aligns with the yunikorn-core master branch. e.g. tryPreemptionLatency not mentioned in doc

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1970

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@brandboat
Copy link
Member Author

gentle ping @HuangTing-Yao, could you take a look ? Many thanks !

Copy link
Contributor

@HuangTing-Yao HuangTing-Yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuangTing-Yao HuangTing-Yao merged commit 4d1b9d4 into apache:master Sep 15, 2023
1 check passed
@brandboat brandboat deleted the yunikorn-1970 branch September 15, 2023 14:14
github-actions bot pushed a commit to steinsgateted/incubator-yunikorn-site that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants