ZOOKEEPER-725: Add unit tests for ConfigUtils.getClientConfigStr #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fabrice-TIERCELIN
changed the title
Fabrice-TIERCELIN
changed the title
|
@maoling, I also have a suggestion for you. GitHub redirects people like me to this page of guidance whereas the guide is here. Perhaps, the link could be changed. |
maoling
approved these changes
Feb 5, 2024
|
@Fabrice-TIERCELIN |
AlphaCanisMajoris
pushed a commit
to AlphaCanisMajoris/zookeeper
that referenced
this pull request
Mar 28, 2024
Reviewers: maoling Author: Fabrice-TIERCELIN Closes apache#2056 from Fabrice-TIERCELIN/unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a unit test method for a not-covered code. The method does 4 tests.
(I do it to learn how to code tests using an AI)