-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apalache.tla: the standard module for Apalache #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
reviewed
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions and plenty of questions for my own edification. None of my feedback should be blocking at all.
tla-import/src/test/scala/at/forsyte/apalache/tla/imp/TestSanyImporter.scala
Outdated
Show resolved
Hide resolved
tla-import/src/test/scala/at/forsyte/apalache/tla/imp/TestSanyImporter.scala
Show resolved
Hide resolved
tlair/src/main/scala/at/forsyte/apalache/tla/lir/oper/BmcOper.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Shon Feder <[email protected]>
Co-authored-by: Shon Feder <[email protected]>
…Importer.scala Co-authored-by: Shon Feder <[email protected]>
Co-authored-by: Shon Feder <[email protected]>
Co-authored-by: Shon Feder <[email protected]>
…scala Co-authored-by: Shon Feder <[email protected]>
Thanks for the comments, @shonfeder! |
Thanks for the replies! |
shonfeder
approved these changes
Jul 31, 2020
I will merge this pull request |
Merged
shonfeder
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Add integration test for TLA_PATH * Fix TLA_PATH Followup to #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #183, this PR introduces the standard module
Apalache.tla
that gives the user access to (almost all of) internal operators introduced by Apalache. Most importantly, it introduces the assignment operatorx := e
. This opens the way to deal with #181.