Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty file error #2821

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

fan-tom
Copy link
Contributor

@fan-tom fan-tom commented Jan 25, 2024

Closes #2800

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (003302f) 78.89% compared to head (f5da1a9) 78.91%.

Files Patch % Lines
...ala/at/forsyte/apalache/tla/imp/SanyImporter.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
+ Coverage   78.89%   78.91%   +0.02%     
==========================================
  Files         467      467              
  Lines       15942    15944       +2     
  Branches     2589     2585       -4     
==========================================
+ Hits        12577    12583       +6     
+ Misses       3365     3361       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fan-tom fan-tom marked this pull request as ready for review January 25, 2024 23:57
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you!

I'll add the changelog entry and merge this in 👯

@shonfeder shonfeder merged commit b8e7c83 into apalache-mc:main Jan 26, 2024
10 checks passed
@apalache-bot apalache-bot mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Exception (java.util.NoSuchElementException: None.get) on empty file input
3 participants