Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tliquidus_max namelist parameter to CICE #104

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

eclare108213
Copy link
Collaborator

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add Tliquidus_max namelist parameter
  • Developer(s):
    @eclare108213
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ran a single case on my laptop:

PASS conda_macos_smoke_gx3_1x1 build
PASS conda_macos_smoke_gx3_1x1 run 9.26 1.59 5.53
PASS conda_macos_smoke_gx3_1x1 test
PASS conda_macos_smoke_gx3_1x1 compare cice0 9.15 1.60 5.50
#machinfo = Generic conda setup
#envinfo macos = (NOTE: may vary) GNU Fortran 7.3.0, clang 9.0.1, openmpi 4.0.2, netcdf 4.5.2

  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No but it will need to, eventually
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

See comments in E3SM-Project/Icepack#13

Copy link
Owner

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the appropriate version of Icepack and all seems fine. I will merge this then update Icepack in a separate PR.

@apcraig
Copy link
Owner

apcraig commented Oct 25, 2022

I'm merging this even though it needs a newer version of Icepack. That step will be taken with a separate PR.

@apcraig apcraig merged commit 59bffba into apcraig:E3SMIcepackDEV Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants