Ignore requests with an invalid sponsor wallet (#1758)

api3dao · May 18, 2023 · be1cb53 · be1cb53
1 parent a379bc0
commit be1cb53
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 21 deletions.
diff --git a/.changeset/young-cougars-nail.md b/.changeset/young-cougars-nail.md
@@ -0,0 +1,5 @@
+---
+'@api3/airnode-node': minor
+---
+
+Ignore requests with an invalid sponsor wallet
diff --git a/packages/airnode-node/src/api/index.ts b/packages/airnode-node/src/api/index.ts
@@ -7,7 +7,7 @@ import axios, { AxiosError } from 'axios';
 import { ethers } from 'ethers';
 import compact from 'lodash/compact';
 import { postProcessApiSpecifications, preProcessApiSpecifications } from './processing';
-import { getAirnodeWalletFromPrivateKey, deriveSponsorWalletFromMnemonic } from '../evm';
+import { getAirnodeWalletFromPrivateKey } from '../evm';
 import { getReservedParameters } from '../adapters/http/parameters';
 import { FIRST_API_CALL_TIMEOUT, SECOND_API_CALL_TIMEOUT } from '../constants';
 import { isValidRequestId } from '../evm/verification';
@@ -101,22 +101,6 @@ export function signWithTemplateId(templateId: string, timestamp: string, data:
   );
 }
 
-export function verifySponsorWallet(payload: RegularApiCallPayload): LogsData<ApiCallErrorResponse> | null {
-  const { config, aggregatedApiCall } = payload;
-
-  const { sponsorAddress, sponsorWalletAddress, id } = aggregatedApiCall;
-  const derivedSponsorWallet = deriveSponsorWalletFromMnemonic(
-    config.nodeSettings.airnodeWalletMnemonic,
-    sponsorAddress
-  );
-  if (derivedSponsorWallet.address === sponsorWalletAddress) return null;
-
-  // TODO: Abstract this to a logging utils file
-  const message = `${RequestErrorMessage.SponsorWalletInvalid}, Request ID:${id}`;
-  const log = logger.pend('ERROR', message);
-  return [[log], { success: false, errorMessage: message }];
-}
-
 export function verifyRequestId(payload: RegularApiCallPayload): LogsData<ApiCallErrorResponse> | null {
   const { aggregatedApiCall } = payload;
 
@@ -165,7 +149,7 @@ export function verifyCallApi(payload: ApiCallPayload) {
 }
 
 export function verifyRegularCallApiParams(payload: RegularApiCallPayload) {
-  const verifications = [verifySponsorWallet, verifyRequestId, verifyTemplateId];
+  const verifications = [verifyRequestId, verifyTemplateId];
 
   return verifications.reduce((result, verifierFn) => {
     if (result) return result;

diff --git a/packages/airnode-node/src/evm/handlers/initialize-provider.ts b/packages/airnode-node/src/evm/handlers/initialize-provider.ts
@@ -182,10 +182,16 @@ export async function initializeProvider(
   );
   logger.logPending(verifyRrpTriggersLogs);
 
+  const [verifySponsorWalletsLogs, verifiedApiCallsForSponsorWallets] = verification.verifySponsorWallets(
+    verifiedApiCallsForRrpTriggers,
+    state4.masterHDNode
+  );
+  logger.logPending(verifySponsorWalletsLogs);
+
   const state5 = state.update(state4, {
     requests: {
       ...state4.requests,
-      apiCalls: verifiedApiCallsForRrpTriggers,
+      apiCalls: verifiedApiCallsForSponsorWallets,
     },
   });
 

diff --git a/packages/airnode-node/src/evm/verification/request-verification.test.ts b/packages/airnode-node/src/evm/verification/request-verification.test.ts
@@ -17,7 +17,7 @@ describe('verifySponsorWallets', () => {
     };
     const invalidApiCall = fixtures.requests.buildApiCall(invalidSponsorWallet);
     const doNotMatchApiCall = fixtures.requests.buildApiCall(sponsorWalletDoesNotBelongToSponsor);
-    const [apiCalllogs, verifiesdApiCalls] = verification.verifySponsorWallets(
+    const [apiCalllogs, verifiedApiCalls] = verification.verifySponsorWallets(
       [invalidApiCall, doNotMatchApiCall],
       masterHDNode
     );
@@ -31,7 +31,7 @@ describe('verifySponsorWallets', () => {
         message: `Invalid sponsor wallet:${doNotMatchApiCall.sponsorWalletAddress} for Request:${doNotMatchApiCall.id}. Expected:0xdBFe14C250643DEFE92C9AbC52103bf4978C7113`,
       },
     ]);
-    expect(verifiesdApiCalls.length).toEqual(0);
+    expect(verifiedApiCalls.length).toEqual(0);
 
     const invalidWithdrawal = fixtures.requests.buildWithdrawal(invalidSponsorWallet);
     const doNotMatchWithdrawal = fixtures.requests.buildWithdrawal(sponsorWalletDoesNotBelongToSponsor);