Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file maintenance #1484

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Lock file maintenance #1484

merged 2 commits into from
Oct 31, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 3, 2022

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 5am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 50e6d32 to 626b7f0 Compare October 5, 2022 14:12
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 8 times, most recently from 9983b77 to f8c8570 Compare October 19, 2022 18:25
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from f8c8570 to a54f7c5 Compare October 20, 2022 15:02
@dcroote
Copy link
Contributor

dcroote commented Oct 21, 2022

The Ignored unknown option { explicitTypes: "always" } warning appears to come from from explicitTypes being removed recently from prettier-plugin-solidity.

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 4 times, most recently from 40c0a89 to 8d2ac2f Compare October 27, 2022 14:26
@amarthadan
Copy link
Contributor

I've removed the deprecated option and let the prettier re-format the files (they've changed the behavior apparently). I think it should be fine but as I'm not familiar with Solidity that much (and don't really know what did that prittier option do) let me know if this should be solved differently. @Siegrift

@amarthadan amarthadan force-pushed the renovate/lock-file-maintenance branch from 7ed422e to f3da4c4 Compare October 28, 2022 06:06
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does impact the contracts code, but tagging @bbenligiray since it does modify the airnode-procotol repository.

@bbenligiray
Copy link
Member

Reformatting shouldn't affect bytecode, this is fine

@amarthadan amarthadan merged commit d236751 into master Oct 31, 2022
@amarthadan amarthadan deleted the renovate/lock-file-maintenance branch October 31, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants