Add CI job to enable/disable GH PR merging #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
Oct 26, 2022
docker/scripts/github.ts
Outdated
| const binKey = sodium.from_base64(repositoryPublicKey, sodium.base64_variants.ORIGINAL); | ||
| const binSecret = sodium.from_string(`${flag}`); | ||
|
|
||
| //Encrypt the secret using LibSodium |
| @@ -56,6 +56,9 @@ | |||
| "docker:scripts:docker:build:local": "yarn docker:scripts:docker:build --npm-registry local --npm-tag local --docker-tag local", | |||
| "docker:scripts:docker:publish": "docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -e DOCKERHUB_USERNAME -e DOCKERHUB_TOKEN api3/airnode-packaging:latest docker publish", | |||
| "docker:scripts:docker:publish:latest": "yarn docker:scripts:docker:publish", | |||
| "docker:scripts:github": "docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -e GITHUB_TOKEN api3/airnode-packaging:latest github", | |||
There was a problem hiding this comment.
You need to set the GH token when running this command. It might be nice to mention this somewhere. Maybe root README?
There was a problem hiding this comment.
There's a README in the docker directory that I'm forgetting to update. I'll do that.
amarthadan
force-pushed
the
packaging-docker-push
branch
2 times, most recently
from
a52476a
to
26d711b
Compare
amarthadan
force-pushed
the
packaging-prevent-merge
branch
2 times, most recently
from
2ddc740
to
ecb6557
Compare
amarthadan
force-pushed
the
packaging-docker-push
branch
2 times, most recently
from
80a3781
to
fc959af
Compare
amarthadan
force-pushed
the
packaging-prevent-merge
branch
from
ecb6557
to
632f93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the release flow, there's a time window when we need to "freeze" merging in order to release only what was tested during the testing of snapshot packages. I added a CI job whose sole purpose is just to check the GitHub secret and succeed or fail based on its value. I also added a command to the packaging container allowing us to set this secret to either
trueorfalse, effectively controlling whether the CI check will be successful and therefore whether the merge will be allowed.