Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to DEBUG log level in airnode-examples #1602

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Default to DEBUG log level in airnode-examples #1602

merged 3 commits into from
Jan 8, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Jan 6, 2023

Closes #1552

@dcroote dcroote self-assigned this Jan 6, 2023
@dcroote dcroote requested a review from Siegrift January 6, 2023 06:08
amarthadan
amarthadan reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add a --debug option to the airnode-deployer commands as well. WDYT?

Siegrift
Siegrift approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @amarthadan , but otherwise 👍 LGTM

@dcroote
Copy link
Contributor Author

dcroote commented Jan 8, 2023

Maybe you can add a --debug option to the airnode-deployer commands as well. WDYT?

Done! Good suggestion. I tested with the basic coingecko integration.

@dcroote dcroote merged commit 0409083 into master Jan 8, 2023
@dcroote dcroote deleted the dcroote/issue1552 branch January 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarthadan amarthadan amarthadan left review comments

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default to DEBUG log level in airnode-examples
3 participants
@dcroote @amarthadan @Siegrift