fix _gasPrice e2e test and simplify getReservedParameterValue #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
approved these changes
Jan 23, 2023
Co-authored-by: Michal Kimle <[email protected]>
dcroote
force-pushed
the
dcroote/fix-gasprice-test
branch
from
3ce8c46
to
4184a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findwasn't working as expected with the async callback. This PR corrects that deficiency and improves the robustness of the test by returning the transcation that used the expectedgasPrice, confirming there was only one such transaction, and re-confirming thegasPrice.The second commit simplifies the return logic of
getReservedParameterValue