Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable number conversion for release CLI #1642

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

amarthadan
Copy link
Contributor

By default, yargs tries to parse everything that looks like a number as a number. This is not desired since some version tags (e.g. 0.10) can be parsed as a number but we need their string representation instead ('0.10' v 0.1).

@amarthadan amarthadan requested a review from a team February 7, 2023 12:30
@amarthadan amarthadan self-assigned this Feb 7, 2023
@amarthadan
Copy link
Contributor Author

The CI fail is caused by #1585. The PR is good to go.

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarthadan amarthadan merged commit 5b2c060 into master Feb 8, 2023
@amarthadan amarthadan deleted the fix-release-script-cli-parsing branch February 8, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants