-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Terraform and plugins #1661
Update Terraform and plugins #1661
Conversation
project = var.gcp_project | ||
schedule_interval = 1 | ||
max_instances = var.disable_concurrency_reservation ? null : 1 | ||
invoke_targets = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH: This formatting looks broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. But it's how the terraform fmt
thinks it's best 🤷♂️ I can add an empty line above invoke_targets
if that helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care that much, it's just that it formatted the whole section for nothing (nothign changed there)
@@ -2,7 +2,7 @@ terraform { | |||
required_providers { | |||
google = { | |||
source = "hashicorp/google" | |||
version = "~> 4.7" | |||
version = "~> 4.54" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so as well at the first glance but it's actually from 7
to 54
. It's not 5.4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
8ac6429 taken from #1659