Simplify OEV GW logic #1671
Merged
Simplify OEV GW logic #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
force-pushed
the
oev-gw-fixes
branch
from
0bf1e55
to
9fc1e97
Compare
patriksimurka
approved these changes
Mar 13, 2023
| encodedParameters: | ||
| '0x3173000000000000000000000000000000000000000000000000000000000000636f696e49640000000000000000000000000000000000000000000000000000657468657265756d000000000000000000000000000000000000000000000000', | ||
| timestamp: '1677747253', | ||
| encodedValue: '0x00000000000000000000000000000000000000000000000000000000000003e8', // 1000 |
There was a problem hiding this comment.
Suggested change
| encodedValue: '0x00000000000000000000000000000000000000000000000000000000000003e8', // 1000 | |
| encodedValue: hexZeroPad(Number(1000).toString(16), 64), |
(nit) You can get rid of these comments this way, both I don't mind keeping it.
amarthadan
force-pushed
the
oev-gw-fixes
branch
from
9fc1e97
to
3336a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1665