Final OEV gateway adjustments #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
changed the title
Siegrift
force-pushed
the
last-oev-fixes
branch
from
f2fa179
to
15bf4b6
Compare
Siegrift
commented
Mar 19, 2023
Siegrift
commented
Mar 19, 2023
Siegrift
commented
Mar 19, 2023
amarthadan
force-pushed
the
oev-gw-fixes-2
branch
from
0175036
to
8a302ae
Compare
amarthadan
suggested changes
Mar 20, 2023
There was a problem hiding this comment.
I'm happy with the fixes you've introduced, less happy about the unnecessary stylistic changes.
Feel free to change the request/response form based on what you're suggesting here (as that brings value).
packages/airnode-examples/integrations/coingecko-http-gateways/config.example.json
Outdated
Show resolved
Hide resolved
Siegrift
commented
Mar 21, 2023
Siegrift
commented
Mar 21, 2023
Siegrift
force-pushed
the
last-oev-fixes
branch
from
add589c
to
5500184
Compare
|
@amarthadan @patriksimurka I've implemented the API shape change discussed in #1676 (comment). I tested the gateway locally on AWS. |
Siegrift
force-pushed
the
last-oev-fixes
branch
from
5500184
to
c37d0bd
Compare
amarthadan
approved these changes
Mar 22, 2023
Siegrift
force-pushed
the
last-oev-fixes
branch
from
22e1079
to
7d8551f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening a PR with the (hopefully final) gateway fixes so that I can work uninterrupted on the relay part, since I actively use the built Airnode images for testing (and don't want to hijack #1676).