Revert back to using beacon array for OEV gateway request/response #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on AWS and it works. |
amarthadan
approved these changes
Mar 24, 2023
packages/airnode-deployer/terraform/aws/templates/oevGw.yaml.tpl
Outdated
Show resolved
Hide resolved
|
The QL check is broken for all PRs as of now and has already been raised #1686 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1690
Beacons order is important when deriving beacon set ID. This was discussed https://api3workspace.slack.com/archives/C043YH02PGQ/p1679575311162519 and also a bit with @amarthadan privately.
The decision was to NOT enforce this and be aligned with the (loose) contract implementation. We agreed to revert back to using arrays for request/response body. It is the responsibility of the OEV gateway caller to pass the beacons in correct order.