Fix Terraform secrets parsing for older TF version #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
force-pushed
the
terraform-fix
branch
from
6758015
to
90293ff
Compare
Siegrift
reviewed
Mar 29, 2023
| @@ -10,7 +10,7 @@ locals { | |||
| # Trim whitespaces from the line | |||
| secrets_lines_trimmed = [for line in local.secrets_lines : trimspace(line)] | |||
| # Discard commented lines (starting with '#') | |||
| secrets_lines_uncommented = [for line in local.secrets_lines_trimmed : line if !startswith(line, "#")] | |||
| secrets_lines_uncommented = [for line in local.secrets_lines_trimmed : line if can(regex("^[^#]+.*$", line))] | |||
There was a problem hiding this comment.
Nit: The + is not necessary in that regex.
Siegrift
approved these changes
Mar 29, 2023
amarthadan
force-pushed
the
terraform-fix
branch
from
90293ff
to
ceb046c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use
regexfunction instead ofstartswithbecause the older Terraform 0.12 used for Airnode v0.10 doesn't support it.Also includes fixes for Docker image builds.
The new regex explenation:
