Fix hardcoded deploymentId in tests & prettier behavior
#1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Backport looks good.
...though at the risk of driving you even crazier on this release 😅 the failing documentation CI is real. Two airnode-examples integration links are broken for v0.10 because the URLs have master in them and the integrations were combined for v0.11 and therefore no longer exist. Specifically:
and
could be fixed by replacing master in the URL with v0.10, or I suppose with a local link e.g.
- [coingecko-signed-data](integrations/coingecko-signed-data/README.md)Which maybe we should do as part of a separate PR as well?
|
I know about that, I encountered it and commented on in #1703 (comment). I didn't consider it worth fixing TBH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #1653 and #1656 to fix failing v0.10.1 release
Edit: For the love of god 🙈 Some
npmdependency changed its requirement for the Node version (presumably without a major version bump) so I had to pin thenpmversion to8.19.4(currently the latest in the8.xbranch). This is needed only for0.10as we've switched to Node 18 in0.11. The change should be fine but I will release snapshot packages for v0.10.1 again just to be on the safe side.