Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging Docker image #1840

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix packaging Docker image #1840

merged 1 commit into from
Jul 25, 2023

Conversation

amarthadan
Copy link
Contributor

At some point hardhat switch from storing the compilers in .cache/hardhat-nodejs/compilers/ to .cache/hardhat-nodejs/compilers-v2. But changing the directory was not enough. For some reason, providing the downloaded amd64 version was not enough to avoid the download. I've removed the download completely and added the solc-linux-amd64-v0.8.9+commit.e5eed63a.does.not.work file which is how hardhat internally marks "broken" native compiler and switches to the wasm one. That one then works as expected, no download required 🙂

@amarthadan amarthadan requested review from aquarat and a team July 24, 2023 14:29
@amarthadan amarthadan self-assigned this Jul 24, 2023
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense as the directory change occurred in v2.12.0 and we jumped from v2.10.2 to v2.14.0 in #1743.

.does.not.work 😅

@amarthadan
Copy link
Contributor Author

The docker build failing is caused by #1585 (we've just released v0.12.0, so there are no changes). It's not affecting anything, merging.

@amarthadan amarthadan merged commit 7f3c492 into master Jul 25, 2023
24 of 25 checks passed
@amarthadan amarthadan deleted the fix-packaging-docker-image branch July 25, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants