Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make operationParameter optional within endpoint parameters #1888

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: make operationParameter optional within endpoint parameters #1888

merged 4 commits into from
Oct 2, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Sep 27, 2023

Closes #1800.

@dcroote dcroote self-assigned this Sep 27, 2023
@dcroote dcroote mentioned this pull request Sep 27, 2023
Closed
Siegrift
Siegrift approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 1da6263 into master Oct 2, 2023
25 checks passed
@dcroote dcroote deleted the dcroote/issue1800 branch October 2, 2023 01:40
Ashar2shahid pushed a commit that referenced this pull request Jan 18, 2024
@dcroote @Ashar2shahid
feat: make operationParameter optional within endpoint parameters (#1888
b335b35 
)

* Bump @api3/ois to v2.2.0 and zod to v3.22.2

* Bump oisFormat in configs and test files

* feat: make operationParameter optional within endpoint parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

@metobom metobom Awaiting requested review from metobom

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow endpoint parameters to not be mapped to operation parameters
2 participants
@dcroote @Siegrift