Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support processing v2 #1914

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Support processing v2 #1914

merged 10 commits into from
Dec 1, 2023

Conversation

Siegrift
Copy link
Contributor

Relates to api3dao/commons#27

Rationale

Read api3dao/commons#32

How to test

I used the development only invoke instructions to invoke signed API with pre/post processing configurations. Specifically:

Copy the pre-processing packages/airnode-examples/integrations/coingecko-pre-processing/config.example.json to packages/airnode-node/config/config.json and run the following:

AIRNODE_WALLET_PRIVATE_KEY=0x8127fa78936ebbd63b3f3e30272631d49abd6714c9349f430c383e52ac773cb9 yarn dev:http-signed-data-invoke -e 0x642598611f0dcbe389079bf555108513e3e8a15991887bb61126b7200f13c666 -p 0x3173690000000000000000000000000000000000000000000000000000000000636f696e49640000000000000000000000000000000000000000000000000000657468657265756d000000000000000000000000000000000000000000000000756e697854696d657374616d70000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000061a56980

Copy the post-processing packages/airnode-examples/integrations/coingecko-post-processing/config.example.json to packages/airnode-node/config/config.json and run the following:

AIRNODE_WALLET_PRIVATE_KEY=0x8127fa78936ebbd63b3f3e30272631d49abd6714c9349f430c383e52ac773cb9 yarn dev:http-signed-data-invoke -e 0x7ad7519b2b0ebd54c68356a314ffcacd7f897a08523e2ec9e0edd837fe995422 -p 0x3173730000000000000000000000000000000000000000000000000000000000636f696e49647300000000000000000000000000000000000000000000000000626974636f696e2c657468657265756d00000000000000000000000000000000767343757272656e6379000000000000000000000000000000000000000000007573640000000000000000000000000000000000000000000000000000000000

@Siegrift Siegrift self-assigned this Nov 18, 2023
This was referenced Nov 18, 2023
Closed
Closed
@Siegrift Siegrift force-pushed the processing-v2 branch 2 times, most recently from 9986ce9 to ca3674d Compare November 27, 2023 10:27
dcroote
dcroote reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure your changes to the processing integrations work?

Neither the instructions you provided in your PR (which required a lot of work to even get to the error i.e. httpSignedDataGateway isn't enabled in config.example.json so http-signed-data-invoke fails) nor following the entire coingecko-pre-processing from scratch work for me.

Both fail with TypeError: Cannot read properties of undefined (reading 'unixTimestamp')

packages/airnode-node/src/api/index.ts Outdated Show resolved Hide resolved
@Siegrift
Copy link
Contributor Author

Siegrift commented Dec 1, 2023

Are you sure your changes to the processing integrations work?

You're right - sorry. I forgot to update the processing snippets after the renaming discussion we had at the docs PR. I also forgot to mention to copy the trigger in the config to the signed data gateway.

Please try again now.

@Siegrift Siegrift requested a review from dcroote December 1, 2023 08:08
dcroote
dcroote approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both pre- and post-processing integrations work now 👍

@Siegrift Siegrift merged commit 37d5a12 into master Dec 1, 2023
25 checks passed
@Siegrift Siegrift deleted the processing-v2 branch December 1, 2023 08:30
@dcroote dcroote added this to the 0.14.0 milestone Dec 2, 2023
Ashar2shahid pushed a commit that referenced this pull request Jan 18, 2024
@Siegrift @Ashar2shahid
Support processing v2 (#1914)
62859be 
* Support processing v2

* Migrate to processing after naming changes

* Remove redundant check

* Update ois and commons

* Add changeset

* Fix tests

* Update OIS version properly

* Use [email protected] and remove typing hacks

* Fix processing snippets, apply PR suggestions

* Properly apply PR suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

@metobom metobom Awaiting requested review from metobom

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Siegrift @dcroote