Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump axios and api3 deps #1921

Merged
merged 3 commits into from
Dec 15, 2023
Merged

feat: Bump axios and api3 deps #1921

merged 3 commits into from
Dec 15, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Dec 11, 2023

Remove reliance on deployed RequesterAuthorizerWithErc721 addresses

Remove reliance on deployed RequesterAuthorizerWithErc721 addresses
@dcroote dcroote added this to the 0.14.0 milestone Dec 11, 2023
@dcroote dcroote self-assigned this Dec 11, 2023
@dcroote dcroote changed the title feat: Bump axios and @api3 deps feat: Bump axios and api3 deps Dec 11, 2023
@bbenligiray
Copy link
Member

I would leave the RequesterAuthorizerWithErc721 stuff in, it's just that the old deployments are no longer valid and should not auto-populate the config. When we deploy the new versions, we want them to auto-populate the config.

@dcroote
Copy link
Contributor Author

dcroote commented Dec 13, 2023

I would leave the RequesterAuthorizerWithErc721 stuff in

Agreed and I should have described the PR better- I've taken out only the code / tests that rely on the existence of a deployment (for which there are none currently)

@bbenligiray
Copy link
Member

If it's going to make things easier later, I can do a Sepolia deployment. I don't expect the contract to change later.

@dcroote
Copy link
Contributor Author

dcroote commented Dec 14, 2023

If it's going to make things easier later, I can do a Sepolia deployment. I don't expect the contract to change later.

If possible I think that would be easiest as then none of the tests or configs would change beyond the new default Sepolia address. I know it isn't high priority to deploy the contract and then release though.

@bbenligiray
Copy link
Member

I deployed RequesterAuthorizerWithErc721 on Sepolia and published @api3/[email protected]

Change RequesterAuthorizerWithErc721 related chainIds to 11155111 to
utilize the Sepolia deployment
@dcroote
Copy link
Contributor Author

dcroote commented Dec 15, 2023

Thank you! I reverted back to the original configs and tests, with minor updates to use the new Sepolia deployment.

Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had forgotten about this 🙏

@dcroote dcroote merged commit b87e0b3 into master Dec 15, 2023
25 checks passed
@dcroote dcroote deleted the dcroote/deps-upgrade branch December 15, 2023 16:09
Ashar2shahid pushed a commit that referenced this pull request Jan 18, 2024
* Update RequesterAuthorizerWithErc721 related tests to use new Sepolia deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants