Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump api3/ois to v2.3.2 #1946

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Bump api3/ois to v2.3.2 #1946

merged 2 commits into from
Feb 6, 2024

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Feb 3, 2024

Needed for Airnode v0.14.1 patch release, see here. My plan is into merge to master, cherry-pick this commit on the v0.14 branch, then release. Sound like a plan?

@dcroote dcroote self-assigned this Feb 3, 2024
@dcroote dcroote requested a review from Siegrift February 3, 2024 21:14
@Siegrift
Copy link
Contributor

Siegrift commented Feb 5, 2024

Sound like a plan?

Yeah, although I don't see the need to rush it. It shouldn't be blocking any feature.

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote
Copy link
Contributor Author

dcroote commented Feb 6, 2024

Yeah, although I don't see the need to rush it. It shouldn't be blocking any feature.

Agreed, and I believe @Ashar2shahid mentioned the possibility of another PR related to increasing memory

@dcroote dcroote merged commit 07e0feb into master Feb 6, 2024
25 checks passed
@dcroote dcroote deleted the dcroote/ois-v2.3.2 branch February 6, 2024 07:50
@Siegrift
Copy link
Contributor

Siegrift commented Feb 7, 2024

and I believe @Ashar2shahid mentioned the possibility of another PR related to increasing memory

Mhh, I think I missed/forget this. Can you give me more context.

@dcroote
Copy link
Contributor Author

dcroote commented Feb 10, 2024

@Ashar2shahid said never mind so we're good

@dcroote dcroote mentioned this pull request Mar 24, 2024
10 tasks
dcroote added a commit that referenced this pull request Mar 26, 2024
dcroote added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants