-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove watch chains script #68
Conversation
} | ||
}, | ||
"browserUrl": "https://basescan.org/" | ||
"name": "Base", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier made these consistent with the other chain files - 2 spaces instead of 4 (the only acceptable number of spaces 😛)
package.json
Outdated
"lint": "yarn lint:eslint && yarn lint:prettier && yarn lint:tsc", | ||
"lint:eslint": "eslint . --ext .js,.ts", | ||
"lint:prettier": "prettier --check \"./**/*.{js,md,json}\"", | ||
"lint:tsc": "tsc --noEmit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is necessary or not, since CI now also runs yarn build
🤷🏻♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe lint:tsc
isn't needed because of yarn build
(and we don't have tsc --noEmit
in other repos), otherwise looks good 👍
Changes
yarn dev
script which provided the option of watching thechains/
directory and immediately regenerated thechains.ts
file. This script is unnecessary and can be dropped in favour of a single development flow for now. Discussion: Fix generate-chains script to work with Prettier v3 #67chokidar
as a devDependency (used for watching files)yarn lint
script to include runningprettier --check
andtsc --noEmit
. I re-ran Prettier as part of this PR and noticed that some of the new chain JSON files weren't formatted. The developer will now be forced to runyarn prettier
before pushing new changes..ts
files. I completely missed this 🤦🏻♂️