This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Add test suite #10
Merged
Add test suite #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this package is private. It is meant to be used to manage
the testing dependencies of the Dredd Hooks template test suite.
Usage:
npm install
I think these are reasonable defaults. Note that I turned the 'use-and' rule on, which wasn't previously enforced.
Add Travis CI badge
The test suite can be executed from the dredd-hooks-template repo, but should utlimately be copied to the language-specific project. Also added a mention of example implementations.
|
For reference, here is a failing build, and a passing build. |
gonzalo-bulnes
commented
Jan 21, 2017
| @@ -74,13 +74,13 @@ Feature: Execution order | |||
| #} | |||
|
|
|||
| """ | |||
| Given I set the environment variables to: | |||
| And I set the environment variables to: | |||
There was a problem hiding this comment.
This change likely doesn't require updating the Dredd hooks repositories, it is only refactoring (and only has a minor impact on readability). I think the linting rule is good to have however, and this gave me the opportunity to check that the build was breaking as expected and the corresponding output was readable.
gonzalo-bulnes
commented
Jan 21, 2017
| "url": "https://github.com/gonzalo-bulnes/dredd-hooks-template/issues" | ||
| }, | ||
| "homepage": "https://github.com/gonzalo-bulnes/dredd-hooks-template#readme", | ||
| "private": true |
There was a problem hiding this comment.
I made this package private, and followed the drafter.js example for the author and license fields.
|
This is really great. Thanks! |
This was referenced Jan 23, 2017
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I maintain the cross-language test suite
I want the features syntax to be validated automatically
So that no errors go unnoticed
See #9 (comment)