-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove filename from the interface #1591
Labels
Comments
honzajavorek
referenced
this issue
in apiaryio/dredd-transactions
Apr 6, 2016
kylef
referenced
this issue
in apiaryio/dredd-transactions
Apr 6, 2016
I guess this is blocked until #227 gets finished. |
The only (?!) reason why describe('without sections', () => {
const filename = 'apiDescription.apib';
const { mediaType, apiElements } = fixtures('without-sections').apib;
const compilationResult = compile(mediaType, apiElements, filename);
it('produces one transaction', () => assert.jsonSchema(compilationResult, createCompilationResultSchema({
transactions: 1,
})));
context('\'origin\'', () => {
it('uses filename as API name', () => assert.equal(compilationResult.transactions[0].origin.apiName, filename));
it('uses empty string as resource group name', () => assert.equal(compilationResult.transactions[0].origin.resourceGroupName, ''));
it('uses URI as resource name', () => assert.equal(compilationResult.transactions[0].origin.resourceName, '/message'));
it('uses method as action name', () => assert.equal(compilationResult.transactions[0].origin.actionName, 'GET'));
});
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current interface counts with
filename
being passed todredd-transactions
as an argument. I designed a new interface in apiaryio/dredd-transactions#3 where it isn't present as it should be deprecated:However, deprecating it isn't such a piece of cake 🍰 we thought with @netmilk, so I'll return the
filename
back to the interface and I'm filing this issue to have a memory that we want to remove it in the future.The text was updated successfully, but these errors were encountered: