Empty strings as valid values for URI parameters

[honzajavorek]

⚠️ Work in progress. Do not merge.

---

This is my attempt to finish the work started in #71 by @motoyasu-saburi and described in apiaryio/dredd#677 and #70. It turns out this is much larger problem then anticipated. It is a breaking change in how Dredd works and it has many corner cases:

• required/optional
• default/example
• null/undefined/empty string
• query/path parameters

Regarding the last point, e.g. we do not want /sth/{param}/sth to work with empty strings, but we do want /sth{?param} to work with empty strings. I suggest we clearly specify all the corner cases (similar to #71 (review)) first, then write a lot of tests and then let's change the implementation and release the next major version of Dredd.

---

@motoyasu-saburi Thank you very much for bringing the whole thing up. You did awesome load of work. No matter any delays, your contribution in the issues and in the PR you started was a great help in understanding the whole problem and will be eternally carved in the history of Dredd development 🙇

[motoyasu-saburi]

I'm sorry.
I couldn't finish this,
because It's problem is large range of influence 😭

I had doubts when challenged fix this problem.

This condition false and true is String.
but I thought param.example and param.default setted to Boolean. 🤔

when 'boolean'
        if param.example isnt 'true' and param.example isnt 'false'

https://github.com/apiaryio/dredd-transactions/blob/master/src/validate-parameters.coffee#L16

P.S.
It was my first OSS activities, I am sorry to cause you inconvenience: bow:

I installing Dredd to the a company project now, and doing missionary of Dredd :) (https://www.slideshare.net/dcubeio/api-blueprint-75780293)
Thank you for develop good project.

Also, I try to challenge this bug.
It seems to easy.
(If I can not be done, I ask for help.)
apiaryio/dredd#709

[honzajavorek]

@motoyasu-saburi No inconvenience at all! I'm very so happy you decided to contribute! It's actually a shame this is much larger problem than I expected. The presentation is awesome! You are doing a great work! 🙇

[honzajavorek]

@motoyasu-saburi Would you mind sending me your e-mail (to [email protected])? I'd like to send you some t-shirts/stickers for all the amazing good you're doing for Dredd 🙂

[honzajavorek]

We're decaffenaiting the codebase (#102, #126). Let's get back to this code as part of tackling the whole URI Parameters can of worms.