Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore tests. #443

Closed
wants to merge 7 commits into from
Closed

Add ability to ignore tests. #443

wants to merge 7 commits into from

Conversation

nweber
Copy link

@nweber nweber commented Apr 14, 2016

Add the 'inverse' of the "only" option; the ability to ignore tests by name.

@netmilk
Copy link
Contributor

netmilk commented Apr 15, 2016

Hey @nweber,

Thanks for the contribution! I'd prefer to call this functionality skip to be consistent in naming with the rest of the project.

@nweber
Copy link
Author

nweber commented Apr 15, 2016

Makes sense. I'll make that change.. I'll also check out the tests; I'm not sure why they're failing. I'll take another shot at running them locally to see what's up. I'll update the pull request when it's sorted out.

@nweber
Copy link
Author

nweber commented Apr 15, 2016

Adjusted naming.
Fixed the failing tests.
I have not added new unit tests yet.

@michalholasek
Copy link
Contributor

I'm very sorry we were not able to get back to this. I need to close this as we're going to work on #705 first, which requires having no pending Pull Requests. Having said that, we plan to revamp whole CLI layer (along with transaction names / paths) in the future, so it is possible we will consider adding --skip functionality aswell.

Thank you for all the work you've put into this!

@michalholasek
Copy link
Contributor

Tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants