Introducing Swagger in Dredd #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #### Swagger | ||
|
|
||
| 1. [`response.schema`](http://swagger.io/specification/#responseSchema) - provided JSON Schema will be used. |
There was a problem hiding this comment.
I think response.examples is given preference.
There was a problem hiding this comment.
when checking validity of response? I think it shouldn't
honzajavorek
force-pushed
the
honzajavorek/swagger-docs
branch
from
88bd38d
to
c40910b
Compare
| @@ -20,6 +19,11 @@ Dredd reads your API description and step by step validates whether your API | |||
| implementation replies with responses as they are described in the | |||
| documentation. | |||
|
|
|||
| ## API Description Formats Support | |||
There was a problem hiding this comment.
Maybe "Supported API Description formats" ?
There was a problem hiding this comment.
Addressed in 5e5c81b.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| This is an example how to create a simple [Express.js][] API backend application tested with Dredd | |||
|
|
|||
| ## Create API Description File | |||
| ## Create an API Description Document | |||
There was a problem hiding this comment.
Addressed in 5e5c81b.
| ### Response Headers Expectations | ||
|
|
||
| - All headers specified in the API description must be present in the response. | ||
| - Names of headers are validated in case-insensitive way. |
There was a problem hiding this comment.
Maybe "validated >the< case-insensitive way" ?
There was a problem hiding this comment.
Addressed in 5e5c81b.
|
@netmilk All comments addressed. Good to merge? |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addressing: