-
Notifications
You must be signed in to change notification settings - Fork 280
Conversation
Related to #660 BREAKING CHANGE: Node 0.10 and 0.12 are not supported anymore. See https://github.com/nodejs/LTS#lts-schedule for details. Node.js 0.10 and 0.12 are both officially dead since 2016-12-31.
c6b25a3
to
e7792ef
Compare
@honzajavorek we should make sure the hook servers use node > 0.12 in their travis jobs. I just had both the goodman and php hooks repo break on the way it was installing dredd previously. And I believe the Travis default is not > 0.12 |
@ddelnano That's very good point! Are you sure Travis' default Node version is less than 4? I found this: travis-ci/travis-ci#5218 |
@honzajavorek doesn't look like it on the latest dredd-hooks-php build that I had to fix a few days ago. |
Here is the link for reference https://travis-ci.org/ddelnano/dredd-hooks-php/jobs/199693011 |
I found this, but to me it seems to be overly complicated. Maybe before_install:
- "nvm install node && nvm use node"
- "node --version"
- "npm --version" would be sufficient. |
@@ -69,7 +69,7 @@ | |||
"lcov-result-merger": "^1.2.0", | |||
"mocha": "^3.0.0", | |||
"mocha-lcov-reporter": "^1.2.0", | |||
"nock": "^8.0.0", | |||
"nock": "^9.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nock could not be updated until now, because they dropped 0.10 and 0.12 support in their new versions. See #660.
@@ -1,6 +1,6 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't actively used anywhere and should be deprecated by #422 in the future, but since it's still in the repo, I've updated it.
@honzajavorek anything else that needs updated before this can be merged? |
I think the only missing part is apiaryio/dredd-hooks-ruby#32 now. |
🚀 Why this change?
Node 0.10 and 0.12 are not supported anymore, so we're removing them from CI and we're removing any related workarounds.
📝 Related issues and Pull Requests
Waits for apiaryio/dredd-transactions#69 and apiaryio/gavel.js#86, closes #660.
✅ What didn't I forget?
npm run lint