Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Drop support for Node 0.10 and 0.12 #716

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Feb 10, 2017

🚀 Why this change?

Node 0.10 and 0.12 are not supported anymore, so we're removing them from CI and we're removing any related workarounds.

📝 Related issues and Pull Requests

Waits for apiaryio/dredd-transactions#69 and apiaryio/gavel.js#86, closes #660.

✅ What didn't I forget?

Related to #660

BREAKING CHANGE: Node 0.10 and 0.12 are not supported anymore.
See https://github.com/nodejs/LTS#lts-schedule for details.
Node.js 0.10 and 0.12 are both officially dead since 2016-12-31.
@ddelnano
Copy link
Contributor

ddelnano commented Feb 10, 2017

@honzajavorek we should make sure the hook servers use node > 0.12 in their travis jobs. I just had both the goodman and php hooks repo break on the way it was installing dredd previously. And I believe the Travis default is not > 0.12

@honzajavorek
Copy link
Contributor Author

@ddelnano That's very good point! Are you sure Travis' default Node version is less than 4? I found this: travis-ci/travis-ci#5218

@ddelnano
Copy link
Contributor

@honzajavorek doesn't look like it on the latest dredd-hooks-php build that I had to fix a few days ago.

screen shot 2017-02-10 at 10 31 56 am

@ddelnano
Copy link
Contributor

Here is the link for reference https://travis-ci.org/ddelnano/dredd-hooks-php/jobs/199693011

@honzajavorek
Copy link
Contributor Author

honzajavorek commented Feb 10, 2017

I found this, but to me it seems to be overly complicated. Maybe

before_install:
  - "nvm install node && nvm use node"
  - "node --version"
  - "npm --version"

would be sufficient. node should be an alias for the latest version of Node.

@@ -69,7 +69,7 @@
"lcov-result-merger": "^1.2.0",
"mocha": "^3.0.0",
"mocha-lcov-reporter": "^1.2.0",
"nock": "^8.0.0",
"nock": "^9.0.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nock could not be updated until now, because they dropped 0.10 and 0.12 support in their new versions. See #660.

@@ -1,6 +1,6 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't actively used anywhere and should be deprecated by #422 in the future, but since it's still in the repo, I've updated it.

@ddelnano
Copy link
Contributor

@honzajavorek anything else that needs updated before this can be merged?

@honzajavorek
Copy link
Contributor Author

I think the only missing part is apiaryio/dredd-hooks-ruby#32 now.

@honzajavorek
Copy link
Contributor Author

honzajavorek commented Feb 27, 2017

@miiila @w-vi I requested a review from both of you, but one review from either of you will do the job. So who comes first, wins 🥇 If the changes are all right, please merge this right away.

@w-vi w-vi merged commit c77d9b2 into master Feb 27, 2017
@w-vi w-vi deleted the honzajavorek/drop-old-node branch February 27, 2017 19:31
@w-vi
Copy link
Contributor

w-vi commented Feb 27, 2017

@HJ @miiila done

🏅 🏆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for 0.10 and 0.12 at the end of 2016
3 participants