mkdir should return ENOENT on Java 6 for non existent parent dirs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xist then ENOENT is thrown. Node actually isn't clear on what should happen here, but the mkdirp module certainly expects ENOENT. In addition the Java 7 version works. I would think that it works because a fileNotFound exception is turned into ENOENT within AsyncFileSystem.
huntc
added a commit
to huntc/Play20
that referenced
this pull request
Apr 7, 2014
…ated js-engine with that dependency. We are using our own publishing of Trireme as we need the patch at apigee/trireme#51 quickly.
huntc
added a commit
to huntc/Play20
that referenced
this pull request
Apr 7, 2014
…ated js-engine with that dependency. We are using our own publishing of Trireme as we need the patch at apigee/trireme#51 quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected
mkdirfor Java 6 such that if there is a parent directory but it does not exist thenENOENTis thrown. Node actually isn't clear on what should happen here, but themkdirpmodule certainly expectsENOENT. In addition the Trireme Java 7 version functions correctly withmkdirp. I would think that Java 7 works because a FileNotFoundException is turned intoENOENTwithin AsyncFileSystem.In addition all node exceptions within
mkdirnow communicate the path in the spirit of providing sufficient debug.