Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest update breaks Asana.com #457

Closed
ggravlingen opened this issue Mar 15, 2021 · 12 comments · Fixed by #460 or #463
Closed

Latest update breaks Asana.com #457

ggravlingen opened this issue Mar 15, 2021 · 12 comments · Fixed by #460 or #463
Assignees
@hwillson
Labels
🐞 bug
Milestone
Release 3.0.1

Comments

@ggravlingen
Copy link

Intended outcome:
I'm trying to visit an organisation in Asana.com.

Actual outcome:
The Asana dashboard does not load. The loading spinner keeps circulating between different Asana assets that are loaded (projects, inbox etc). When disabling the Apollo Chrome extension, the page loads. I can also access the page when re-enabling the extension.

How to reproduce the issue:

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Browser version Version 89.0.4389.82 (Official Build) (64-bit)
  • Extension version 3.0.0

Possibly related to #455?
@hwillson hwillson self-assigned this Mar 15, 2021
@ggravlingen
Copy link
Author

ggravlingen commented Mar 15, 2021 •
edited
Loading

Some console output:

[2021-03-15T15:47:18.240Z] Created early WebSocket with PageLoad shard specification
bundle.js:2 Uncaught TypeError: Cannot set property 'exports' of undefined
    at Object.<anonymous> (bundle.js:2)
    at Object.page_load_bundle_evaluation_failure_checker (bundle.js:2)
    at o (bundle.js:2)
    at Object.page_load_bundle_evaluation_failure_checker (bundle.js:2)
    at o (bundle.js:2)
    at bundle.js:2
    at bundle.js:2
start_session?path=%2F0%2Fhome%2F1199901208724637&query_string=&rparam=01807108763015184487&user_id=_id=&t=1615823238124&k=key_one&h=&release_revision=20210311_181458_b09cbd9598bedb2b021fbe939c388a2a1f8accd2&sync_cluster=prod:1 Uncaught ReferenceError: Deserializer is not defined
    at start_session:1
    at start_session:1

@hwillson
Copy link
Member

Thanks @ggravlingen - definitely sounds like the same problem.

@hwillson hwillson added this to the Release 3.0.1 milestone Mar 15, 2021
@ecwyne ecwyne mentioned this issue Mar 15, 2021
Closed
hwillson added a commit that referenced this issue Mar 15, 2021
@hwillson
Update to the latest ts-invariant version
10b0306 
This will allow us to pull in the changes from
apollographql/invariant-packages#91.

Fixes #455
Fixes #457
@hwillson hwillson mentioned this issue Mar 15, 2021
Merged
hwillson added a commit that referenced this issue Mar 15, 2021
@hwillson
Update to the latest ts-invariant version
a8cda67 
This will allow us to pull in the changes from
apollographql/invariant-packages#91.

Fixes #455
Fixes #457
@HeyParkerJ
Copy link

HeyParkerJ commented Mar 15, 2021 •
edited
Loading

Latest update also broke TargetProcess for people in my organization.

I can toggle this extension to break/fix Targetprocess's initial loading screen with full consistency.

@hwillson
Copy link
Member

Fixed in #460, but re-opening until the new version is published.

@hwillson hwillson reopened this Mar 15, 2021
@hwillson
Copy link
Member

Apollo Client Devtools 3.0.1 has been submitted for review; 🤞it will be available shortly.

@hwillson
Copy link
Member

3.0.1 should be available now - let me know if this issue still occurs. Thanks!

@ggravlingen
Copy link
Author

Thanks for looking into this! I'm on 3.0.1 now and unfortunately, the error still persists. Same error in console as yesterday. Is there any more data I can retrieve on my end in order to help?

image

@jfirebaugh
Copy link

Same here, on version 3.0.1 and I couldn't use Asana until I disabled the extension.

@hwillson hwillson reopened this Mar 17, 2021
hwillson added a commit that referenced this issue Mar 18, 2021
@hwillson
Update the @apollo/client dep to pull in ts-invariant changes
10f52bf 
The issues fixed by #460 didn't quite go far enough. This commit
updates to more recent versions of `@apollo/client`, and ultimately
`ts-invariant`, to pull in the changes made in
apollographql/invariant-packages#94.

Fixes #457
@hwillson hwillson mentioned this issue Mar 18, 2021
Merged
@hwillson
Copy link
Member

3.0.2 has been submitted for review with a fix for this - thanks!

@hwillson
Copy link
Member

3.0.2 has been published and this issue appears to be fixed. Let us know otherwise. Thanks!

@ggravlingen
Copy link
Author

Just confirming that it works on 3.0.2. Thanks for your help!

@hwillson
Copy link
Member

Phew - thanks @ggravlingen and sorry about that!

hwillson added a commit that referenced this issue Mar 26, 2021
@hwillson
Delay Apollo Client initialization in browser tabs until needed
19a25cf 
Apollo Client and its associated dependencies do not need to load
on each browser tab, if the Apollo Client Devtools extension is
not being used. These changes avoid loading / initializing AC
and its deps, until they are really needed.

This is ultimately a better fix for #457, which was being caused
by Apollo Client's dependency `ts-invariant` being loaded
when the devtools were initialized, even though they weren't
being used on certain sites.
@hwillson hwillson mentioned this issue Mar 26, 2021
Merged
hwillson added a commit that referenced this issue Mar 26, 2021
@hwillson
Delay Apollo Client initialization in browser tabs until needed
b3b37f7 
Apollo Client and its associated dependencies do not need to load
on each browser tab, if the Apollo Client Devtools extension is
not being used. These changes avoid loading / initializing AC
and its deps, until they are really needed.

This is ultimately a better fix for #457, which was being caused
by Apollo Client's dependency `ts-invariant` being loaded
when the devtools were initialized, even though they weren't
being used on certain sites.
hwillson added a commit that referenced this issue Mar 26, 2021
@hwillson
Delay Apollo Client initialization in browser tabs until needed (#479)
f281596 
Apollo Client and its associated dependencies do not need to load
on each browser tab, if the Apollo Client Devtools extension is
not being used. These changes avoid loading / initializing AC
and its deps, until they are really needed.

This is ultimately a better fix for #457, which was being caused
by Apollo Client's dependency `ts-invariant` being loaded
when the devtools were initialized, even though they weren't
being used on certain sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwillson hwillson

Labels
🐞 bug
Projects
None yet
Milestone
Release 3.0.1
4 participants
@jfirebaugh @hwillson @HeyParkerJ @ggravlingen