Add history navigation to cache tab #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#503 Bundle Size — 1.26MiB (+0.29%).Warning Bundle contains 12 duplicate packages – View duplicate packages Bundle metrics
|
| Current #503 |
Baseline #499 |
|
|---|---|---|
 Initial JS |
1.23MiB(+0.3%) |
1.22MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
91.15% |
0% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
944(+0.43%) |
940 |
| Duplicate Modules |
45 |
45 |
| Duplicate Code |
3.87%(-0.26%) |
3.88% |
| Packages |
160 |
160 |
| Duplicate Packages |
9 |
9 |
Bundle size by type 1 change 1 regression
| Current #503 |
Baseline #499 |
|
|---|---|---|
| JS |
1.23MiB (+0.3%) |
1.22MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch jerel/cache-history Project dashboard
jerelmiller
commented
May 30, 2024
| { | ||
| variants: { | ||
| variant: { | ||
| error: [ |
There was a problem hiding this comment.
For now we only need the error variant, so I've only implemented this one. We can add others as we need them.
jerelmiller
commented
May 30, 2024
| @@ -39,9 +46,11 @@ function filterCache(cache: Cache, searchTerm: string) { | |||
| ); | |||
| } | |||
|
|
|||
| const history = new History("ROOT_QUERY"); | |||
There was a problem hiding this comment.
Instantiating this outside of the component allows us to keep the history when changing tabs, otherwise this resets anytime the Cache component unmounts.
jerelmiller
commented
May 30, 2024
| setCacheId={setCacheId} | ||
| searchTerm={searchTerm} | ||
| /> | ||
| <List> |
There was a problem hiding this comment.
This component was fairly small and "EntityList" wasn't a super great name for this anyways, so I went ahead and inlined the implementation here and removed the old component.
alessbell
approved these changes
Jun 6, 2024
| return ( | ||
| <Root> | ||
| <Root delayDuration={delayDuration}> |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a forward/back button with history to the cache tab. This should make it easier to navigate back and forth when digging into more complex objects that have lots of nested normalized data.
Previously getting back to where you were would require you to start back at either the root query or have to manually search the cache for the entry you came from.