Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON parse/stringify cache data in queries to avoid serialization error #1481

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Aug 23, 2024

Fixes #1479

#1418 did an optimization where only the data for the tab you're viewing is transferred between the content scripts and devtools. That data used to all be sent together and serialization errors were avoided by running a JSON.parse(JSON.stringify(...)) on the entire data set. In making the change in #1418 however, it now only applies this to the cache tab data. We also send cache data for the queries tab which needs this fix as well.

@jerelmiller jerelmiller requested a review from a team as a code owner August 23, 2024 14:44
@jerelmiller jerelmiller changed the title json parse/stringify cache data in queries to avoid serialization error JSON parse/stringify cache data in queries to avoid serialization error Aug 23, 2024
Copy link

relativeci bot commented Aug 23, 2024

#797 Bundle Size — 1.51MiB (~+0.01%).

9bd32f9(current) vs ba6cefd main#795(baseline)

Warning

Bundle contains 13 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#797
     Baseline
#795
Regression  Initial JS 1.47MiB(~+0.01%) 1.47MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 1.06% 0%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 1213 1213
No change  Duplicate Modules 45 45
No change  Duplicate Code 3.07% 3.07%
No change  Packages 183 183
No change  Duplicate Packages 10 10
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#797
     Baseline
#795
Regression  JS 1.47MiB (~+0.01%) 1.47MiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/serialize-queries-cacheProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this out there! :)

@jerelmiller jerelmiller merged commit d065fca into main Aug 23, 2024
9 checks passed
@jerelmiller jerelmiller deleted the jerel/serialize-queries-cache branch August 23, 2024 15:22
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in the queries tab in apollo dev tools [Vue Application]
2 participants